aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSankar P <psankar@novell.com>2008-12-08 13:56:00 +0800
committerSankarasivasubramanian Pasupathilingam <psankar@src.gnome.org>2008-12-08 13:56:00 +0800
commit85bea601b3a38b36aca0adb4824019d151703294 (patch)
tree4cf0675ba2de354f81400b8f2da5f6bb43d05a28
parent60a043e1a8da877cd60100c8ece4cc0bf3be1508 (diff)
downloadgsoc2013-evolution-85bea601b3a38b36aca0adb4824019d151703294.tar
gsoc2013-evolution-85bea601b3a38b36aca0adb4824019d151703294.tar.gz
gsoc2013-evolution-85bea601b3a38b36aca0adb4824019d151703294.tar.bz2
gsoc2013-evolution-85bea601b3a38b36aca0adb4824019d151703294.tar.lz
gsoc2013-evolution-85bea601b3a38b36aca0adb4824019d151703294.tar.xz
gsoc2013-evolution-85bea601b3a38b36aca0adb4824019d151703294.tar.zst
gsoc2013-evolution-85bea601b3a38b36aca0adb4824019d151703294.zip
** Fixes bug #552583
2008-12-08 Sankar P <psankar@novell.com> ** Fixes bug #552583 * mail-config.c (mail_config_get_account_by_source_url), (mail_config_get_account_by_transport_url): Fix bugs in the account checking logic. svn path=/branches/gnome-2-24/; revision=36840
-rw-r--r--mail/ChangeLog8
-rw-r--r--mail/mail-config.c24
2 files changed, 17 insertions, 15 deletions
diff --git a/mail/ChangeLog b/mail/ChangeLog
index a80721555b..86679a68ee 100644
--- a/mail/ChangeLog
+++ b/mail/ChangeLog
@@ -1,3 +1,11 @@
+2008-12-08 Sankar P <psankar@novell.com>
+
+ ** Fixes bug #552583
+
+ * mail-config.c (mail_config_get_account_by_source_url),
+ (mail_config_get_account_by_transport_url):
+ Fix bugs in the account checking logic.
+
2008-12-04 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #552583
diff --git a/mail/mail-config.c b/mail/mail-config.c
index 976b031b05..0d3db2f0d4 100644
--- a/mail/mail-config.c
+++ b/mail/mail-config.c
@@ -817,14 +817,11 @@ mail_config_get_account_by_source_url (const char *source_url)
e_iterator_next (iter);
- if (account->source == NULL)
- continue;
-
- else if (account->source->url == NULL)
- continue;
-
- else if (*account->source->url == '\0')
+ if ( !account || (account->source == NULL) ||
+ (account->source->url == NULL) || (*account->source->url == '\0')) {
+ account = NULL;
continue;
+ }
account_url = camel_url_new (account->source->url, NULL);
if (account_url == NULL)
@@ -861,14 +858,11 @@ mail_config_get_account_by_transport_url (const char *transport_url)
e_iterator_next (iter);
- if (account->transport == NULL)
- continue;
-
- else if (account->transport->url == NULL)
- continue;
-
- else if (*account->transport->url == '\0')
- continue;
+ if ( !account || (account->transport == NULL) ||
+ (account->transport->url == NULL) || (*account->transport->url == '\0')) {
+ account = NULL;
+ continue;
+ }
account_url = camel_url_new (account->transport->url, NULL);
if (account_url == NULL)