diff options
| author | Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk> | 2013-08-08 01:29:15 +0800 |
|---|---|---|
| committer | Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk> | 2013-08-08 15:42:54 +0800 |
| commit | be542f50da6bc3e7d24b808aac16b1f542be7dc0 (patch) | |
| tree | dfdf6e52d0e23f17e301500e3e6f2494c8a8f8ff | |
| parent | 57a1c2ea90fa02bfeea2c24570132681e8dd22e8 (diff) | |
| download | gsoc2013-empathy-be542f50da6bc3e7d24b808aac16b1f542be7dc0.tar gsoc2013-empathy-be542f50da6bc3e7d24b808aac16b1f542be7dc0.tar.gz gsoc2013-empathy-be542f50da6bc3e7d24b808aac16b1f542be7dc0.tar.bz2 gsoc2013-empathy-be542f50da6bc3e7d24b808aac16b1f542be7dc0.tar.lz gsoc2013-empathy-be542f50da6bc3e7d24b808aac16b1f542be7dc0.tar.xz gsoc2013-empathy-be542f50da6bc3e7d24b808aac16b1f542be7dc0.tar.zst gsoc2013-empathy-be542f50da6bc3e7d24b808aac16b1f542be7dc0.zip | |
Don't dereference a NULL error
libsecret returns FALSE without an error in some cases but we
unconditionally dereference it, causing a crash.
https://bugzilla.gnome.org/show_bug.cgi?id=692105
| -rw-r--r-- | libempathy/empathy-keyring.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libempathy/empathy-keyring.c b/libempathy/empathy-keyring.c index 40667342f..367346b0a 100644 --- a/libempathy/empathy-keyring.c +++ b/libempathy/empathy-keyring.c @@ -656,7 +656,8 @@ items_delete_cb (GObject *source, GSimpleAsyncResult *simple = G_SIMPLE_ASYNC_RESULT (user_data); GError *error = NULL; - if (!secret_password_clear_finish (result, &error)) + secret_password_clear_finish (result, &error); + if (error != NULL) { g_simple_async_result_set_error (simple, TP_ERROR, TP_ERROR_DOES_NOT_EXIST, "%s", error->message); |