summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTing-Wei Lan <lantw44@gmail.com>2013-09-06 18:32:04 +0800
committerLAN-TW <lantw44@gmail.com>2013-09-06 18:32:04 +0800
commit1aafa63a8e84566bd5911fee1d445f36bbc36466 (patch)
tree757d86326c9d97f46649f22675e5fd2b3a7a4552
parent3defbdd1594ff2a8d1c1fa7a523f6cf77d8f697a (diff)
downloadgsoc2013-libgnome-autoar-1aafa63a8e84566bd5911fee1d445f36bbc36466.tar
gsoc2013-libgnome-autoar-1aafa63a8e84566bd5911fee1d445f36bbc36466.tar.gz
gsoc2013-libgnome-autoar-1aafa63a8e84566bd5911fee1d445f36bbc36466.tar.bz2
gsoc2013-libgnome-autoar-1aafa63a8e84566bd5911fee1d445f36bbc36466.tar.lz
gsoc2013-libgnome-autoar-1aafa63a8e84566bd5911fee1d445f36bbc36466.tar.xz
gsoc2013-libgnome-autoar-1aafa63a8e84566bd5911fee1d445f36bbc36466.tar.zst
gsoc2013-libgnome-autoar-1aafa63a8e84566bd5911fee1d445f36bbc36466.zip
Prevent using g_return_val_if_fail to check error
-rw-r--r--gnome-autoar/autoar-create.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/gnome-autoar/autoar-create.c b/gnome-autoar/autoar-create.c
index 3c178bd..30cf04a 100644
--- a/gnome-autoar/autoar-create.c
+++ b/gnome-autoar/autoar-create.c
@@ -424,7 +424,10 @@ libarchive_write_open_cb (struct archive *ar_write,
G_FILE_CREATE_NONE,
arcreate->priv->cancellable,
&(arcreate->priv->error));
- g_return_val_if_fail (arcreate->priv->error == NULL, ARCHIVE_FATAL);
+ if (arcreate->priv->error != NULL) {
+ g_debug ("libarchive_write_open_cb: ARCHIVE_FATAL");
+ return ARCHIVE_FATAL;
+ }
g_debug ("libarchive_write_open_cb: ARCHIVE_OK");
return ARCHIVE_OK;
@@ -479,7 +482,8 @@ libarchive_write_write_cb (struct archive *ar_write,
length,
arcreate->priv->cancellable,
&(arcreate->priv->error));
- g_return_val_if_fail (arcreate->priv->error == NULL, -1);
+ if (arcreate->priv->error != NULL)
+ return -1;
g_debug ("libarchive_write_write_cb: %lu", write_size);
return write_size;